Treat conditional types as unions #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR improves the handling of conditional types by treating them as unions in the type resolver and providing corresponding tests.
- Adds new test cases in test/conditional-types (input.ts and output.json) to validate conditional types support
- Updates src/parsers/typeResolver.ts to resolve conditional types by combining their true and false branches into a union node
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| test/conditional-types/output.json | Introduces a JSON output describing conditional type exports |
| test/conditional-types/input.ts | Provides test functions and components using conditional types |
| src/parsers/typeResolver.ts | Refactors conditional type resolution to return union nodes for both branches |
commit: |
michaldudak
force-pushed
the
conditional-types
branch
from
8111498 to
0d99e7e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a conditional type is encountered, we consider both branches as possible values:
T extends S ? A : Bgenerates a UnionNode with A and B as member types.